Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

route53_info: Add RETURN block #1240

Merged
merged 5 commits into from
Jun 17, 2022
Merged

route53_info: Add RETURN block #1240

merged 5 commits into from
Jun 17, 2022

Conversation

mandar242
Copy link
Contributor

@mandar242 mandar242 commented Jun 15, 2022 •
edited
Loading

SUMMARY

Currently route53_info is mising a return block.

This is a follow up on #1236

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

route53_info

@ansibullbot
Copy link

cc @Etherdaemon @jillr @markuman @s-hertel @tremble
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage plugins plugin (any type) labels Jun 15, 2022
@github-actions
Copy link

github-actions bot commented Jun 15, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

❌ ansible-galaxy-importer FAILURE in 4m 06s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 43s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 47s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 44s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 02s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 56s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 4m 59s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 40s
✔️ ansible-test-splitter SUCCESS in 2m 22s
✔️ integration-community.aws-1 SUCCESS in 6m 57s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

jatorcasso
jatorcasso reviewed Jun 15, 2022
View reviewed changes
Copy link
Contributor

@jatorcasso jatorcasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add version_added since these are new return values. Also, is it worth documenting the deprecated return values? Im not sure if thats necessary or not

@mandar242
Copy link
Contributor Author

can you please add version_added since these are new return values. Also, is it worth documenting the deprecated return values? Im not sure if thats necessary or not

sure added version_added. I'm not sure which values you mean here 'documenting the deprecated return values' ?

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

❌ ansible-galaxy-importer FAILURE in 5m 43s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 42s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 16s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 53s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 58s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 55s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 08s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 27s
✔️ ansible-test-splitter SUCCESS in 2m 24s
✔️ integration-community.aws-1 SUCCESS in 7m 20s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@jatorcasso
Copy link
Contributor

can you please add version_added since these are new return values. Also, is it worth documenting the deprecated return values? Im not sure if thats necessary or not

sure added version_added. I'm not sure which values you mean here 'documenting the deprecated return values' ?

The CamelCased keys that will still be returned until we remove them

@gravesm
Copy link
Member

gravesm commented Jun 16, 2022

I would document the deprecated keys with a note about the deprecation, but skip adding the contains block for them. I think it's worth telling users about their existence, but we don't need the full documentation for them

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

❌ ansible-galaxy-importer FAILURE in 4m 01s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 45s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 27s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 33s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 18s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 19s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 44s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 49s
✔️ ansible-test-splitter SUCCESS in 2m 24s
✔️ integration-community.aws-1 SUCCESS in 6m 48s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

jatorcasso
jatorcasso approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@jatorcasso jatorcasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think version added should be 3.4.0 if I'm not mistaken - aside from that LGTM!

@mandar242 mandar242 requested a review from gravesm June 17, 2022 16:25
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

❌ ansible-galaxy-importer FAILURE in 4m 52s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 39s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 05s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 45s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 40s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 01s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 36s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 05s
✔️ ansible-test-splitter SUCCESS in 2m 25s
✔️ integration-community.aws-1 SUCCESS in 7m 42s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@mandar242 mandar242 added the mergeit Merge the PR (SoftwareFactory) label Jun 17, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

❌ ansible-galaxy-importer FAILURE in 4m 19s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 40s
✔️ ansible-test-sanity-docker-devel SUCCESS in 18m 12s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 45s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 17s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 20s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 08s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 51s
✔️ ansible-test-splitter SUCCESS in 2m 25s
✔️ integration-community.aws-1 SUCCESS in 6m 49s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 6e7f150 into ansible-collections:main Jun 17, 2022
@mandar242 mandar242 deleted the route53_info_return_block branch June 17, 2022 21:42
@renovate renovate bot mentioned this pull request Jun 24, 2022
Merged
1 task
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@mandar242 @goneri
route53_info: Add RETURN block (ansible-collections#1240)
a5b462b 
route53_info: Add RETURN block

SUMMARY

Currently route53_info is mising a return block.
This is a follow up on ansible-collections#1236

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

route53_info

Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Mike Graves <mgraves@redhat.com>
Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@6e7f150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gravesm gravesm gravesm approved these changes

@jatorcasso jatorcasso jatorcasso approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review mergeit Merge the PR (SoftwareFactory) module module needs_triage plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mandar242 @ansibullbot @jatorcasso @gravesm